Merge runtime type-checking wrappers into a single layer (BEAM-9489)#39206
Merge runtime type-checking wrappers into a single layer (BEAM-9489)#39206lakshitbahl wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes the Apache Beam Python SDK's runtime type-checking mechanism by merging two previously nested wrapper classes into a single, more efficient implementation. This change reduces the number of function calls per element processed when runtime type checking is enabled, while maintaining full support for input/output validation and descriptive error reporting. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Run Yaml_Xlang_Direct PreCommit |
|
/gemini review |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request merges TypeCheckWrapperDoFn and OutputCheckWrapperDoFn into a single RuntimeTypeCheckWrapperDoFn to eliminate a level of Python call indirection per element during runtime type-checking. It also adds corresponding unit tests and regression tests for stateful DoFns. The review feedback suggests optimizing performance by caching the unbound process function and a self parameter flag during initialization, avoiding the overhead of calling _process_argspec_fn() on every processed element.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| if self._input_hints: | ||
| actual_inputs = inspect.getcallargs( | ||
| self.dofn._process_argspec_fn(), *args, **kwargs) # pylint: disable=deprecated-method |
There was a problem hiding this comment.
Use the cached unbound function self._process_fn and self._has_self flag to perform type checking. This avoids calling self.dofn._process_argspec_fn() on every processed element, significantly improving element-processing performance.
| if self._input_hints: | |
| actual_inputs = inspect.getcallargs( | |
| self.dofn._process_argspec_fn(), *args, **kwargs) # pylint: disable=deprecated-method | |
| if self._input_hints: | |
| if self._has_self: | |
| actual_inputs = inspect.getcallargs( | |
| self._process_fn, self.dofn, *args, **kwargs) # pylint: disable=deprecated-method | |
| else: | |
| actual_inputs = inspect.getcallargs( | |
| self._process_fn, *args, **kwargs) # pylint: disable=deprecated-method |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
Run Python_ML PreCommit |
lakshitbahl
force-pushed
the
fix-beam-20226-runtime-typecheck
branch
from
a118353 to
e132e01
Compare
|
Assigning reviewers: R: @tvalentyn for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
1 participant
Description
This PR resolves BEAM-9489 by merging the runtime type-checking wrappers into a single layer to avoid redundant nested wrapper executions.
Changes
typecheck.pyto ensure visitor pattern collapses duplicate wrapper layers.RuntimeTypeCheckWrapperDoFnTestclass totypecheck_test.pywith 3 comprehensive validation tests verifying single-layer application, error messaging labeling, and element-processing preservation.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.