[#28420] Fix type inference for closures over local variables#39210
Open
lakshitbahl wants to merge 1 commit into
Open
[#28420] Fix type inference for closures over local variables#39210lakshitbahl wants to merge 1 commit into
lakshitbahl wants to merge 1 commit into
Conversation
Contributor
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
###Description:
This PR resolves closure-related type inference regressions (see #28420) and restores compatibility with Python 3.11+ opcode changes. It introduces two distinct fixes under a unified closure-handling improvement, allowing us to un-skip testLocalClosure.
Type-vs-Value Cell Confusion
Prevents the inference engine from confusing synthetic inferred types with real runtime closure values. Introduces the _TypeInCell marker class to safely wrap, track, and unwrap inferred types within the frame emulation, ensuring strict isolation from actual Python cell contents.
Python 3.11+ Shared-Slot Indexing
Fixes LOAD_CLOSURE and LOAD_DEREF indexing for Python 3.11 and newer. Replaces the legacy arg -= len(co_varnames) arithmetic, which broke when captured parameters shared a slot in the new unified localsplus array with version-aware slot-name resolution. This correctly maps variables and prevents out-of-bounds IndexError exceptions that were previously being swallowed by the safe-mode execution and degraded to Any.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.