MAINT: typing pyrit.models#2116
Merged
rlundeen2 merged 3 commits intoJul 2, 2026
Merged
Conversation
Reuse typed component identifiers (Phase 21 candidates C3, C4, C6): narrow param bags to dict[str, JSONValue], read target identity via TargetIdentifier, and rebuild the attack converter-merge path with typed identifier constructors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
behnam-o
approved these changes
Jul 2, 2026
romanlutz
approved these changes
Jul 2, 2026
…g-pyrit-models # Conflicts: # pyrit/backend/models/converters.py
component_identifier here is a generic ComponentIdentifier (often a converter, not a target), so coercing it via TargetIdentifier.from_component_identifier broke on non-target identifiers and mocks. Restore the generic params.get(...) reads for model_name/endpoint. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuses typed component identifiers to tighten typing across
pyrit.modelsand its consumers: narrows the*_specific_paramsbags todict[str, JSONValue], reads target identity viaTargetIdentifier, and rebuilds the attack converter-merge path with typed identifier constructors (hash-stable). Implements Phase 21 candidates C3, C4, and C6 from the pydantic models plan gist.