Include proxy config source in telemetry event#324056
Open
chrmarti wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends proxy-resolution support in the extension host and uses it in the Copilot extension’s fetcher telemetry so the event includes not only the resolved proxy type but also which proxy configuration source determined the result.
Changes:
- Expose
resolveProxyByURLfrom the extension host’s patched@vscode/proxy-agentmodule alongsideresolveProxyURL. - Update Copilot fetcher telemetry collection to resolve and emit both
proxyTypeand a newproxySourcefield (with timeout/missing/error sentinels).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/api/node/proxyResolver.ts | Exposes resolveProxyByURL on the patched @vscode/proxy-agent export used in the extension host. |
| extensions/copilot/src/extension/log/vscode-node/loggingActions.ts | Switches telemetry proxy resolution to resolveProxyByURL and adds proxySource to the emitted telemetry properties and GDPR annotation. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
chrmarti
force-pushed
the
chrmarti/naval-bandicoot
branch
from
914d090 to
d5bb9c1
Compare
chrmarti
force-pushed
the
chrmarti/naval-bandicoot
branch
from
d5bb9c1 to
906f5df
Compare
pwang347
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.